-
Notifications
You must be signed in to change notification settings - Fork 191
Deprecate DynamicCircuitInstructionDurations and provide alternative via Target
#2403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… input, deprecate DynamicCircuitInstructionDurations
…skit-ibm-runtime into instr-durations-cleanup
Collaborator
|
Thanks @ElePT! Can you also update the code example in https://github.com/Qiskit/qiskit-ibm-runtime/blob/main/qiskit_ibm_runtime/transpiler/passes/scheduling/__init__.py? |
…skit-ibm-runtime into instr-durations-cleanup
DynamicCircuitInstructionDurations and provide alternative via TargetDynamicCircuitInstructionDurations and provide alternative via Target
kt474
approved these changes
Oct 13, 2025
Member
kt474
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Missing points:
This PR deprecates the
DynamicCircuitInstructionDurationsclass, a class that performed some Eagle-specific optimizations that have fallen out of date, and don't provide any advantage on Herons. This class was used in thedurationsinput of the scheduling passes, which has also been deprecated in favor of providing thetargetdirectly to the passes. This allows for a better integration with the overall qiskit transpilation pipeline, which has almost fully transitioned towards the use oftargetas opposed to loose constraints.Details and comments
Fixes #